Align Bill-to Name 2 editability with the other bill-to address fields on sales documents#9096
Conversation
…s on sales documents The Bill-to Name 2 field on Sales Order, Sales Quote, Blanket Sales Order, and Sales Invoice was only editable with the Another Customer bill-to option. Every other field in the bill-to address group is editable when Custom Address is selected or when the bill-to customer differs from the sell-to customer. The field was missed when that editability logic was applied to the group. The same correction is propagated to the country layers that carry copies of these pages (APAC, BE, CH, ES, FR, GB, IT, NA, NL, NO, RU), and the existing bill-to editability tests now cover the field.
Agentic PR Review - Round 1Recommendation: Accept with SuggestionsWhat this PR doesThis PR makes Bill-to Name 2 use the same Editable and Enabled expressions as the other bill-to address fields on Sales Quote, Sales Order, Sales Invoice, and Blanket Sales Order pages. The change matches the sibling fields: the field is available for Custom Address and when the bill-to customer differs from the sell-to customer. The fix addresses the reported root cause. I checked the target page copies and found the Bill-to Name 2 expressions are now consistent with Bill-to Address, Address 2, City, Post Code, Country/Region Code, Contact No., and Contact. Sales Credit Memo and Sales Return Order are not part of this change because they do not use the same BillToOptions control flow. SuggestionsS1 - Test Enabled state for Name 2 Risk assessment and necessityRisk: Low. The change is limited to page control properties and does not change table fields, validation logic, posting logic, events, or public APIs. The main regression surface is UI editability for bill-to address fields on sales documents. Necessity: The change is necessary because GitHub issue #8312 gives a clear user scenario: Custom Address allows editing the other bill-to address fields but not Bill-to Name 2. No ADO work item was linked, so this assessment relies on the GitHub issue and the diff.
|
Copilot PR ReviewIteration 1 · Outcome: completed
Knowledge source: https://github.com/microsoft/BCQuality@822cae1b2771ac25f665f73369f69093bd4fd630 Orchestrator pre-filter (13 file(s) excluded)
Findings produced by the Copilot CLI agent against BCQuality at |
Review feedback: the change touches both Editable and Enabled, so the four extended tests now assert both states for the field.
|
Thanks for the review. S1 is addressed in 14decc6: the four extended tests now assert both Editable and Enabled for Bill-to Name 2. On the failing checks, if I am not mistaken they look unrelated to this change: Unit Tests (NZ) failed downloading its artifact (ECONNRESET), and the Unit Tests (SE) failures are Sustainability approval workflow tests reporting a missing Sustainability Setup record, which this PR does not touch. A re-run would probably clear both. |
Agentic PR Review - Round 2Recommendation: AcceptWhat this PR doesSince round 1, the PR only updates W1 test coverage. It adds This addresses the open round-1 concern. The new assertions check the same control whose Status of previous suggestions
New observations (commits since round 1)None - changes only addressed prior suggestions. Risk assessment and necessityRisk: Low. The round-2 diff touches only test code. The runtime change remains limited to page control properties and does not change table validation, posting logic, events, or public APIs. Necessity: The GitHub bug describes a clear inconsistency: Custom Address unlocks sibling bill-to fields but not Bill-to Name 2. The new commit is necessary because the original test update covered Editable but not Enabled, even though both properties changed.
|
What & why
On the Sales Order, Sales Quote, Blanket Sales Order, and Sales Invoice pages, "Bill-to Name 2" is only editable when the Bill-to option is "Another Customer". Every other field in the bill-to address group (Address, Address 2, City, County, Post Code, Country/Region Code, Contact No., Contact) is editable when "Custom Address" is selected or when the bill-to customer differs from the sell-to customer. As noted in the issue triage, the field was simply missed when that editability logic was applied to the group.
This change gives "Bill-to Name 2" the same Editable and Enabled expression as the rest of the group on those four pages. The country layers that carry copies of these pages (APAC, BE, CH, ES, FR, GB, IT, NA, NL, NO, RU) receive the identical two-property change, following the established practice of propagating W1 fixes to the localization layers.
Linked work
Fixes #8312
How I validated this
What I tested and the outcome
Risk & compatibility